Update worker to use new leaderboard #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthur29
force-pushed
the
update_worker_to_use_new_leaderboard
branch
from
a0c7d5e
to
de96bdd
Compare
mathnogueira
approved these changes
May 18, 2021
Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com>
mathnogueira
added a commit
that referenced
this pull request
May 19, 2021
Co-authored-by: Arthur Nogueira Gonçalves <arthur.nogueira@wildlifestudios.com> Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
Currently worker directly connect to redis to execute your operations, and it still using the old
Luascript. This PR proposes to move this flow to use leaderboard instead of actual approach.WHAT WAS DONE
configfrom testing to a proper packageLeaderboardWithoutMemberToExpireErrorerror on databaseZRangeByScoreto RedisSRemto accept more than one member to removeExpireinterface and implement it onRedis