Avoid logging when no pushes were sent

topfreegames · Jan 25, 2018 · 11b5d3f · 11b5d3f
1 parent 21012f6
commit 11b5d3f
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 24 deletions.
diff --git a/extensions/apns_message_handler.go b/extensions/apns_message_handler.go
@@ -346,18 +346,20 @@ func (a *APNSMessageHandler) LogStats() {
 	ticker := time.NewTicker(a.LogStatsInterval)
 	for range ticker.C {
 		apnsResMutex.Lock()
-		l.WithFields(log.Fields{
-			"sentMessages":      a.sentMessages,
-			"ignoredMessages":   a.ignoredMessages,
-			"responsesReceived": a.responsesReceived,
-			"successesReceived": a.successesReceived,
-			"failuresReceived":  a.failuresReceived,
-		}).Info("flushing stats")
-		a.sentMessages = 0
-		a.responsesReceived = 0
-		a.ignoredMessages = 0
-		a.successesReceived = 0
-		a.failuresReceived = 0
+		if a.sentMessages > 0 || a.responsesReceived > 0 || a.ignoredMessages > 0 || a.successesReceived > 0 || a.failuresReceived > 0 {
+			l.WithFields(log.Fields{
+				"sentMessages":      a.sentMessages,
+				"ignoredMessages":   a.ignoredMessages,
+				"responsesReceived": a.responsesReceived,
+				"successesReceived": a.successesReceived,
+				"failuresReceived":  a.failuresReceived,
+			}).Info("flushing stats")
+			a.sentMessages = 0
+			a.responsesReceived = 0
+			a.ignoredMessages = 0
+			a.successesReceived = 0
+			a.failuresReceived = 0
+		}
 		apnsResMutex.Unlock()
 	}
 }

diff --git a/extensions/gcm_message_handler.go b/extensions/gcm_message_handler.go
@@ -385,18 +385,20 @@ func (g *GCMMessageHandler) LogStats() {
 	ticker := time.NewTicker(g.LogStatsInterval)
 	for range ticker.C {
 		apnsResMutex.Lock()
-		l.WithFields(log.Fields{
-			"sentMessages":      g.sentMessages,
-			"responsesReceived": g.responsesReceived,
-			"ignoredMessages":   g.ignoredMessages,
-			"successesReceived": g.successesReceived,
-			"failuresReceived":  g.failuresReceived,
-		}).Info("flushing stats")
-		g.sentMessages = 0
-		g.responsesReceived = 0
-		g.successesReceived = 0
-		g.ignoredMessages = 0
-		g.failuresReceived = 0
+		if g.sentMessages > 0 || g.responsesReceived > 0 || g.ignoredMessages > 0 || g.successesReceived > 0 || g.failuresReceived > 0 {
+			l.WithFields(log.Fields{
+				"sentMessages":      g.sentMessages,
+				"responsesReceived": g.responsesReceived,
+				"ignoredMessages":   g.ignoredMessages,
+				"successesReceived": g.successesReceived,
+				"failuresReceived":  g.failuresReceived,
+			}).Info("flushing stats")
+			g.sentMessages = 0
+			g.responsesReceived = 0
+			g.successesReceived = 0
+			g.ignoredMessages = 0
+			g.failuresReceived = 0
+		}
 		apnsResMutex.Unlock()
 	}
 }