Skip to content

Commit

Permalink
Move all integ tests into a same Spec and mark the ones failing previ…
Browse files Browse the repository at this point in the history
…ously as Pending

There were an "Integration" and an "Integration2" test Spec. Only
Integration2 was being ran by our targets, I put all tests under the
same Spec and marked the ones in "Integration" that were failing as
pending. Also modified the `make integration` target to skip unit tests
and focus only in Integration ones
  • Loading branch information
Flavia Pezoti committed Jul 9, 2020
1 parent a90bd59 commit 4fdcc86
Show file tree
Hide file tree
Showing 8 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ cache:
directories:
- "$HOME/.cache/librdkafka"
before_install:
- sudo /bin/bash ./travis_install_kafka.sh
- sudo /bin/bash ./travis-install-librkafka.sh
install:
- make setup-ci
script:
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ test-integration integration func: deps test-db-drop test-db-create
@echo "= Running integration tests... ="
@echo "-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-="
@echo
@env MY_IP=${MY_IP} ginkgo -r -tags=integration --randomizeAllSpecs --randomizeSuites --skip="\[Integration\].*" .
@env MY_IP=${MY_IP} ginkgo -r -tags=integration --randomizeAllSpecs --randomizeSuites --focus="\[Integration\].*" .
@echo
@echo "-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-="
@echo "= Integration tests finished. ="
Expand Down
2 changes: 1 addition & 1 deletion extensions/gcm_message_handler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -702,7 +702,7 @@ var _ = Describe("GCM Message Handler", func() {
hook.Reset()
})

Describe("Creating new handler", func() {
PDescribe("Creating new handler", func() {
It("should fail when real client", func() {
var err error
handler, err = NewGCMMessageHandler(
Expand Down
2 changes: 1 addition & 1 deletion extensions/kafka_consumer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ var _ = Describe("Kafka Extension", func() {
})
})

Describe("ConsumeLoop", func() {
PDescribe("ConsumeLoop", func() {
It("should consume message and add it to msgChan", func() {
stopChannel := make(chan struct{})
client, err := NewKafkaConsumer(config, logger, &stopChannel)
Expand Down
2 changes: 1 addition & 1 deletion extensions/pg_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ var _ = Describe("PG Extension", func() {
})

Describe("[Integration]", func() {
Describe("Creating new client", func() {
PDescribe("Creating new client", func() {
It("should return connected client", func() {
client, err := NewPGClient("push.db", config)
Expect(err).NotTo(HaveOccurred())
Expand Down
2 changes: 1 addition & 1 deletion feedback/kafka_consumer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ var _ = Describe("Kafka Consumer", func() {
})
})

Describe("[Integration2]", func() {
Describe("[Integration]", func() {
var config *viper.Viper
var err error

Expand Down
2 changes: 1 addition & 1 deletion feedback/listener_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ var _ = Describe("Feedback Listener", func() {
}
})

Describe("[Integration2]", func() {
Describe("[Integration]", func() {
Describe("Create a new instance of listener", func() {
var logger *logrus.Logger

Expand Down
File renamed without changes.

0 comments on commit 4fdcc86

Please sign in to comment.