Skip to content

Commit

Permalink
Remove raven-go since it is breaking our builds. Revert this ASAP.
Browse files Browse the repository at this point in the history
  • Loading branch information
cscatolini committed Jan 20, 2017
1 parent f60b5a4 commit 68f6c75
Show file tree
Hide file tree
Showing 7 changed files with 2 additions and 43 deletions.
10 changes: 0 additions & 10 deletions cmd/apns.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import (
"fmt"

"github.com/Sirupsen/logrus"
raven "github.com/getsentry/raven-go"
"github.com/spf13/cobra"
"github.com/spf13/viper"
"github.com/topfreegames/pusher/interfaces"
Expand Down Expand Up @@ -77,17 +76,8 @@ var apnsCmd = &cobra.Command{
panic(err)
}

sentryURL := config.GetString("sentry.url")
if sentryURL != "" {
raven.SetDSN(sentryURL)
}

apnsPusher, err := startApns(debug, json, production, certificate, config, nil, nil, nil)
if err != nil {
raven.CaptureErrorAndWait(err, map[string]string{
"version": util.Version,
"cmd": "apns",
})
panic(err)
}
apnsPusher.Start()
Expand Down
10 changes: 0 additions & 10 deletions cmd/gcm.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import (
"fmt"

"github.com/Sirupsen/logrus"
raven "github.com/getsentry/raven-go"
"github.com/spf13/cobra"
"github.com/spf13/viper"
"github.com/topfreegames/pusher/interfaces"
Expand Down Expand Up @@ -82,17 +81,8 @@ var gcmCmd = &cobra.Command{
panic(err)
}

sentryURL := config.GetString("sentry.url")
if sentryURL != "" {
raven.SetDSN(sentryURL)
}

gcmPusher, err := startGcm(debug, json, production, senderID, apiKey, config, nil, nil, nil)
if err != nil {
raven.CaptureErrorAndWait(err, map[string]string{
"version": util.Version,
"cmd": "gcm",
})
panic(err)
}
gcmPusher.Start()
Expand Down
6 changes: 0 additions & 6 deletions extensions/kafka_consumer.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,8 @@ import (

"github.com/Sirupsen/logrus"
"github.com/confluentinc/confluent-kafka-go/kafka"
raven "github.com/getsentry/raven-go"
"github.com/spf13/viper"
"github.com/topfreegames/pusher/interfaces"
"github.com/topfreegames/pusher/util"
)

// KafkaConsumer for getting push requests
Expand Down Expand Up @@ -288,10 +286,6 @@ func (q *KafkaConsumer) handleError(ev kafka.Event) {
"method": "handleError",
})
err := ev.(error)
raven.CaptureError(err, map[string]string{
"version": util.Version,
"extension": "kafka-consumer",
})
l.WithError(err).Error("Error in Kafka connection.")
}

Expand Down
6 changes: 0 additions & 6 deletions extensions/kafka_producer.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,8 @@ package extensions
import (
log "github.com/Sirupsen/logrus"
"github.com/confluentinc/confluent-kafka-go/kafka"
raven "github.com/getsentry/raven-go"
"github.com/spf13/viper"
"github.com/topfreegames/pusher/interfaces"
"github.com/topfreegames/pusher/util"
)

// KafkaProducer for producing push feedbacks to a kafka queue
Expand Down Expand Up @@ -96,10 +94,6 @@ func (q *KafkaProducer) listenForKafkaResponses() {
case *kafka.Message:
m := ev
if m.TopicPartition.Error != nil {
raven.CaptureError(m.TopicPartition.Error, map[string]string{
"version": util.Version,
"extension": "kafka-producer",
})
l.WithError(m.TopicPartition.Error).Error("error sending feedback to kafka")
} else {
l.WithFields(log.Fields{
Expand Down
6 changes: 0 additions & 6 deletions extensions/token_pg.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,8 @@ import (
"fmt"

"github.com/Sirupsen/logrus"
raven "github.com/getsentry/raven-go"
"github.com/spf13/viper"
"github.com/topfreegames/pusher/interfaces"
"github.com/topfreegames/pusher/util"
)

// TokenPG for sending metrics
Expand Down Expand Up @@ -82,10 +80,6 @@ func (t *TokenPG) HandleToken(token string) error {
query := fmt.Sprintf("DELETE FROM %s WHERE token = ?0;", t.tableName)
_, err := t.Client.DB.Exec(query, token)
if err != nil && err.Error() != "pg: no rows in result set" {
raven.CaptureError(err, map[string]string{
"version": util.Version,
"extension": "token-pg",
})
l.WithError(err).Error("error deleting token")
return err
}
Expand Down
6 changes: 2 additions & 4 deletions glide.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion glide.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,5 @@ import:
- mock
- package: github.com/alexcesaro/statsd
version: ^2.0.0
- package: github.com/getsentry/raven-go
- package: github.com/certifi/gocertifi
version: ^2016.9.26

0 comments on commit 68f6c75

Please sign in to comment.