Logs should not interpolate strings.

topfreegames · Jan 19, 2017 · e8d531e · e8d531e
1 parent 696e19c
commit e8d531e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/extensions/apns_message_handler.go b/extensions/apns_message_handler.go
@@ -237,7 +237,7 @@ func (a *APNSMessageHandler) handleAPNSResponse(res push.Response) error {
 	inflightMessagesMetadataLock.Unlock()
 
 	if err != nil {
-		l.Errorf("error sending feedback to reporter: %v", err)
+		l.WithError(err).Error("error sending feedback to reporter")
 	}
 	if res.Err != nil {
 		pushError, ok := res.Err.(*push.Error)

diff --git a/extensions/gcm_message_handler.go b/extensions/gcm_message_handler.go
@@ -199,7 +199,7 @@ func (g *GCMMessageHandler) handleGCMResponse(cm gcm.CCSMessage) error {
 
 	err = sendToFeedbackReporters(g.feedbackReporters, ccsMessageWithMetadata)
 	if err != nil {
-		l.Errorf("error sending feedback to reporter: %v", err)
+		l.WithError(err).Error("error sending feedback to reporter")
 	}
 	if cm.Error != "" {
 		pErr := errors.NewPushError(strings.ToLower(cm.Error), cm.ErrorDescription)

diff --git a/extensions/kafka_consumer.go b/extensions/kafka_consumer.go
@@ -267,7 +267,7 @@ func (q *KafkaConsumer) handlePartitionEOF(ev kafka.Event) {
 		"partition": fmt.Sprintf("%v", ev),
 	})
 
-	l.Debugf("Reached partition EOF.")
+	l.Debug("Reached partition EOF.")
 }
 
 func (q *KafkaConsumer) handleOffsetsCommitted(ev kafka.Event) {
@@ -276,7 +276,7 @@ func (q *KafkaConsumer) handleOffsetsCommitted(ev kafka.Event) {
 		"partition": fmt.Sprintf("%v", ev),
 	})
 
-	l.Debugf("Offsets committed successfully.")
+	l.Debug("Offsets committed successfully.")
 }
 
 func (q *KafkaConsumer) handleError(ev kafka.Event) {