Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Fixes the certificate tests that was breaking due to an updated introduced in go1.11 that changed the behaviour of the
VerifyHostNameFunction
(https://tip.golang.org/doc/go1.11#crypto/x509). The fix is based on a commit done in the sideshow/apns2 repo which the original code was based on.Removed declared but not used variables in
apns_message_handler.go
andgcm_message_handler.go
that were preventing the tests from running.Update the Gokpkg.lock file with fields introduced in dep v0.5.0 (https://golang.github.io/dep/blog/2018/07/25/announce-v0.5.0.html)