Move all integ tests into a same Spec and mark the ones failing as Pending #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ously as Pending There were an "Integration" and an "Integration2" test Spec. Only Integration2 was being ran by our targets, I put all tests under the same Spec and marked the ones in "Integration" that were failing as pending. Also modified the `make integration` target to skip unit tests and focus only in Integration ones
Build with this version is broken and it's not being used in our deployment process
|
I recommend going commit through commit, since last commit is mostly lint changes that impact a high number of files |
leohahn
reviewed
Jul 10, 2020
leohahn
reviewed
Jul 10, 2020
flapezoti
force-pushed
the
fix-ci
branch
2 times, most recently
from
5c6df6b
to
c8d7156
Compare
leohahn
reviewed
Jul 13, 2020
leohahn
reviewed
Jul 13, 2020
leohahn
reviewed
Jul 13, 2020
leohahn
reviewed
Jul 13, 2020
leohahn
reviewed
Jul 13, 2020
leohahn
reviewed
Jul 13, 2020
leohahn
reviewed
Jul 13, 2020
leohahn
reviewed
Jul 13, 2020
leohahn
reviewed
Jul 13, 2020
leohahn
reviewed
Jul 13, 2020
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were an "Integration" and an "Integration2" test Spec. Only
Integration2 was being ran by our targets, I put all tests under the
same Spec and marked the ones in "Integration" that were failing as
pending. Also modified the
make integrationtarget to skip unit testsand focus only in Integration ones