Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: revert 614 to remove the -p option #713

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

SteveLauC
Copy link
Member

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself

For new steps

  • Optional: Topgrade skips this step where needed
  • Optional: The --dry-run option works with this step
  • Optional: The --yes option works with this step if it is supported by
    the underlying command

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

Revert PR #614 as the -p option does not work properly.

Closes #709

@SteveLauC SteveLauC merged commit c6e3f0a into topgrade-rs:main Feb 24, 2024
9 checks passed
@SteveLauC SteveLauC deleted the revert/614 branch February 24, 2024 03:26
@SteveLauC SteveLauC mentioned this pull request Apr 18, 2024
4 tasks
InnocentZero pushed a commit to InnocentZero/topgrade that referenced this pull request May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Topgrade cannot upgrade zshell framework (https://wiki.zshell.dev)
1 participant