Skip to content
This repository has been archived by the owner on Apr 18, 2023. It is now read-only.

fix: update to link #192

Merged
merged 5 commits into from Jun 2, 2021
Merged

fix: update to link #192

merged 5 commits into from Jun 2, 2021

Conversation

BisuGit
Copy link
Collaborator

@BisuGit BisuGit commented Jun 1, 2021

Description

  • Removed gesture recognizer and attributes to mimic a link.
  • Added .link attribute to handle intended link behaviour.

DevQA

DevQA Prep

  • Run pod install
  • Test RichTextView to ensure that it passes (unit and UI tests)
  • Navigate to the Example project in the root Example folder and run the app
  • Ensure that everything in the Example app looks visually correct

DevQA Steps

Comments

@BisuGit BisuGit changed the title update to link fix: update to link Jun 1, 2021
@tophat-danger
Copy link

1 Message
📖

If anything other than RichTextView appears in the code coverage section please add it
to the exclude_targets property of the xcov.report() function in the Dangerfile

Current coverage for RichTextView.framework is 89.81%

Files changed - -
UITextViewGenerator.swift 54.05% ⚠️
RichTextParser.swift 92.63%

Powered by xcov

Generated by 🚫 Danger

@BisuGit BisuGit added the reviewme Indicates a PR that needs to be reviewed label Jun 1, 2021
Copy link
Collaborator

@maicon-brauwers maicon-brauwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, better native solution.

@maicon-brauwers maicon-brauwers added approved Indicates a PR that has passed code review and removed reviewme Indicates a PR that needs to be reviewed labels Jun 2, 2021
@BisuGit BisuGit merged commit 025071f into master Jun 2, 2021
@BisuGit BisuGit deleted the Update-Use-link-attributes branch June 2, 2021 13:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR that has passed code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants