Skip to content
This repository has been archived by the owner on Apr 18, 2023. It is now read-only.

Add tooltip, isEditable, and ability to respond to href links #75

Merged
merged 1 commit into from Dec 7, 2018

Conversation

aelkady
Copy link
Contributor

@aelkady aelkady commented Dec 7, 2018

Description

DevQA

DevQA Prep

  • Run pod install
  • Test RichTextView to ensure that it passes (unit and UI tests)
  • Navigate to the Example project in the root Example folder and run the app
  • Ensure that everything in the Example app looks visually correct

DevQA Steps

  • Make sure that changes above are reflected in the example project

@tophat-danger
Copy link

2 Messages
📖 Please ensure that your new files respect the existing folder structure
📖

If anything other than RichTextView appears in the code coverage section please add it
to the exclude_targets property of the xcov.report() function in the Dangerfile

Current coverage for RichTextView.framework is 90.32%

Files changed - -
RichTextView.swift 86.26%
UITextViewGenerator.swift 94.44%

Powered by xcov

Generated by 🚫 Danger

Copy link
Contributor

@OrlaM OrlaM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OrlaM OrlaM added approved Indicates a PR that has passed code review devQA-approved Indicates a PR that has been successfully devQA'd labels Dec 7, 2018
@aelkady aelkady merged commit a1c5c4a into master Dec 7, 2018
@aelkady aelkady deleted the feature/add-selectable-and-editable branch December 7, 2018 16:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR that has passed code review devQA-approved Indicates a PR that has been successfully devQA'd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants