Fix/chromedriver version #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrome has bumped to v56 - chromedriver's version doesn't work anymore neither the update version -> so the e2e tests fail angular/protractor#3639 (comment)
topheman
added a commit
to topheman/vanilla-es6-jspm
that referenced
this pull request
Mar 10, 2017
topheman
added a commit
to topheman/vanilla-es6-jspm
that referenced
this pull request
Mar 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18
Since chrome 56,
webdriver updatewon't work properly. Found a fix by using chromedriver npm package and referencing it inprotractor.config.jsfile aschromeDriver: './node_modules/chromedriver/lib/chromedriver/chromedriver',.See : angular/protractor#3639 (comment)
Anyone who'd like to help to upgrade protractor from v3 to v5 is welcome.