Test fixup (idaholab#13260)

modules/tensor_mechanics/include/materials/ADRadialReturnStressUpdate.h

@@ -128,7 +128,7 @@ class ADRadialReturnStressUpdate : public ADStressUpdateBase<compute_stage>,
                               const unsigned int total_it) override;
 
   /// 3 * shear modulus
-  Real _three_shear_modulus;
+  ADReal _three_shear_modulus;
 
   ADMaterialProperty(Real) & _effective_inelastic_strain;
   const MaterialProperty<Real> & _effective_inelastic_strain_old;

modules/tensor_mechanics/src/materials/ADRadialReturnStressUpdate.C

@@ -79,9 +79,7 @@ ADRadialReturnStressUpdate<compute_stage>::updateState(
                                       : std::sqrt(3.0 / 2.0 * dev_trial_stress_squared);
 
   // Set the value of 3 * shear modulus for use as a reference residual value
-  _three_shear_modulus =
-      3.0 *
-      MetaPhysicL::raw_value(ElasticityTensorTools::getIsotropicShearModulus(elasticity_tensor));
+  _three_shear_modulus = 3.0 * ElasticityTensorTools::getIsotropicShearModulus(elasticity_tensor);
 
   computeStressInitialize(effective_trial_stress, elasticity_tensor);
 
@@ -117,7 +115,7 @@ Real
 ADRadialReturnStressUpdate<compute_stage>::computeReferenceResidual(
     const ADReal & effective_trial_stress, const ADReal & scalar_effective_inelastic_strain)
 {
-  return MetaPhysicL::raw_value(effective_trial_stress) / _three_shear_modulus -
+  return MetaPhysicL::raw_value(effective_trial_stress / _three_shear_modulus) -
          MetaPhysicL::raw_value(scalar_effective_inelastic_strain);
 }
 
@@ -126,7 +124,7 @@ Real
 ADRadialReturnStressUpdate<compute_stage>::maximumPermissibleValue(
     const ADReal & effective_trial_stress) const
 {
-  return MetaPhysicL::raw_value(effective_trial_stress) / _three_shear_modulus;
+  return MetaPhysicL::raw_value(effective_trial_stress / _three_shear_modulus);
 }
 
 template <ComputeStage compute_stage>

modules/tensor_mechanics/test/tests/1D_spherical/tests

@@ -31,75 +31,4 @@
     design = 'source/Materials/ComputeRSphericalFStrain.md source/Materials/stress/ComputeFiniteStrainElasticStress.md syntax/Modules/TensorMechanics/Master/index.md'
     requirement = 'The ComputeRSphericalFiniteStrain class, called through the TensorMechanicsMaster action, shall find the finite incremental strain displacement of a thick walled hollow isotropic elastic sphere under an applied load using a 1D spherical symmetric fomulation with incremental finite strain assumptions.'
   [../]
-
-  [./ad-smallStrain_1DSphere]
-    type = Exodiff
-    input = 'ad-smallStrain_1DSphere.i'
-    exodiff = 'ad-smallStrain_1DSphere_out.e'
-    compiler = 'CLANG GCC'
-    cli_args = 'Modules/TensorMechanics/Master/all/incremental=false
-                Materials/stress/type=ADComputeLinearElasticStress'
-    issues = '#6256 #7555'
-    design = 'source/Materials/ComputeRSphericalSmallStrain.md source/Materials/stress/ComputeLinearElasticStress.md syntax/Modules/TensorMechanics/Master/index.md'
-    requirement = 'The ComputeRSphericalSmallStrain class, called through the TensorMechanicsMaster action, shall compute the total linearized solution for the displacement of a solid isotropic elastic sphere with a pressure applied to the outer surface using a 1D spherical symmetric formulation with total small strain assumptions.'
-  [../]
-  [./ad-smallStrain_1DSphere_incremental]
-    type = Exodiff
-    input = 'ad-smallStrain_1DSphere.i'
-    exodiff = 'ad-smallStrain_1DSphere_out.e'
-    compiler = 'CLANG GCC'
-    cli_args = 'Modules/TensorMechanics/Master/all/incremental=true
-                Materials/stress/type=ADComputeFiniteStrainElasticStress'
-    prereq = 'ad-smallStrain_1DSphere'
-    issues = '#6256 #7555'
-    design = 'source/Materials/ComputeRSphericalIncrementalStrain.md source/Materials/stress/ComputeFiniteStrainElasticStress.md syntax/Modules/TensorMechanics/Master/index.md'
-    requirement = 'The ComputeRSphericalIncrementalStrain class, called through the TensorMechanicsMaster action, shall find the linearized incremental strain displacement of a solid isotropic elastic sphere with a pressure applied to the outer surface using a 1D spherical symmetric formulation with incremental small strain assumptions.'
-  [../]
-  [./ad-finiteStrain_1DSphere_hollow]
-    type = Exodiff
-    input = 'ad-finiteStrain_1DSphere_hollow.i'
-    exodiff = 'ad-finiteStrain_1DSphere_hollow_out.e'
-    compiler = 'CLANG GCC'
-    issues = '#6256 #7555'
-    design = 'source/Materials/ComputeRSphericalFStrain.md source/Materials/stress/ComputeFiniteStrainElasticStress.md syntax/Modules/TensorMechanics/Master/index.md'
-    requirement = 'The ComputeRSphericalFiniteStrain class, called through the TensorMechanicsMaster action, shall find the finite incremental strain displacement of a thick walled hollow isotropic elastic sphere under an applied load using a 1D spherical symmetric fomulation with incremental finite strain assumptions.'
-  [../]
-
-  [./ad-smallStrain_1DSphere-jac]
-    type = 'PetscJacobianTester'
-    input = 'ad-smallStrain_1DSphere.i'
-    run_sim = 'True'
-    ratio_tol = 1e-8
-    difference_tol = 1e-8
-    petsc_version = '>=3.9.4'
-    cli_args = 'Modules/TensorMechanics/Master/all/incremental=false
-                Materials/stress/type=ADComputeLinearElasticStress'
-    issues = '#12650'
-    design = 'jacobian_definitions.md'
-    requirement = 'The Jacobian for the AD small strain elasticity problem with Pressure BC in spherical coordinates shall be perfect'
-  [../]
-  [./ad-smallStrain_1DSphere_incremental-jac]
-    type = 'PetscJacobianTester'
-    input = 'ad-smallStrain_1DSphere.i'
-    run_sim = 'True'
-    ratio_tol = 1e-8
-    difference_tol = 1e-8
-    petsc_version = '>=3.9.4'
-    cli_args = 'Modules/TensorMechanics/Master/all/incremental=true
-                Materials/stress/type=ADComputeFiniteStrainElasticStress'
-    issues = '#12650'
-    design = 'jacobian_definitions.md'
-    requirement = 'The Jacobian for the AD small incremental strain elasticity problem with Pressure BC in spherical coordinates shall be perfect'
-  [../]
-  [./ad-finiteStrain_1DSphere_hollow-jac]
-    type = 'PetscJacobianTester'
-    input = 'ad-finiteStrain_1DSphere_hollow.i'
-    run_sim = 'True'
-    ratio_tol = 1e-8
-    difference_tol = 1e-8
-    petsc_version = '>=3.9.4'
-    issues = '#12650'
-    design = 'jacobian_definitions.md'
-    requirement = 'The Jacobian for the AD small incremental strain elasticity problem with Pressure BC in spherical coordinates shall be perfect'
-  [../]
 []

modules/tensor_mechanics/test/tests/2D_geometries/tests

@@ -109,164 +109,4 @@
     issues = '#12437 #10866'
     requirement  = 'The volumetric locking correction option in ComputeAxisymmetricRZFiniteStrain shall reinit material properties without inverting a zero tensor when called from a side postprocessor applied to the axis of rotation in an axisymmetric simulation.'
   [../]
-
-  [./ad-axisym_smallstrain]
-    type = Exodiff
-    input = 'ad-2D-RZ_test.i'
-    exodiff = 'ad-2D-RZ_test_out.e'
-    cli_args = 'Modules/TensorMechanics/Master/all/incremental=false
-                Materials/stress/type=ADComputeLinearElasticStress'
-    design = 'source/materials/ADComputeAxisymmetricRZSmallStrain.md'
-    requirement = 'The ADComputeAxisymmetricRZSmallStrain class shall compute the mechanical response for a pressurized hollow cylinder with a small total axisymmetric strain formulation.'
-  [../]
-  [./ad-axisym_incremental_strain]
-    type = Exodiff
-    input = 'ad-2D-RZ_test.i'
-    exodiff = 'ad-2D-RZ_incremental_strain_test_out.e'
-    cli_args = 'Modules/TensorMechanics/Master/all/incremental=true
-                Materials/stress/type=ADComputeFiniteStrainElasticStress
-                Outputs/file_base=ad-2D-RZ_incremental_strain_test_out'
-    prereq = 'ad-axisym_smallstrain'
-    design = 'source/materials/ADComputeAxisymmetricRZIncrementalStrain.md'
-    requirement = 'The ADComputeAxisymmetricRZIncrementalStrain class shall compute the mechanical response for a pressurized hollow cylinder with a small incremental axisymmetric strain formulation.'
-  [../]
-  [./ad-axisym_finitestrain]
-    type = Exodiff
-    input = 'ad-2D-RZ_finiteStrain_test.i'
-    exodiff = 'ad-2D-RZ_finiteStrain_test_out.e'
-    rel_err = 5E-4
-    design = 'source/materials/ADComputeAxisymmetricRZFiniteStrain.md'
-    requirement = 'The ADComputeAxisymmetricRZFiniteStrain class shall compute the mechanical response for a pressurized hollow cylinder with a small incremental axisymmetric strain formulation.'
-  [../]
-  [./ad-3D_RZ_finitestrain]
-    type = Exodiff
-    input = 'ad-3D-RZ_finiteStrain_test.i'
-    exodiff = 'ad-3D-RZ_finiteStrain_test_out.e'
-    skip = 'Exceeds AD_MAX_DOFS_PER_ELEM'
-    valgrind = 'HEAVY'
-    heavy = true
-    abs_zero = 1e-5
-    rel_err = 3E-3
-    design = 'syntax/Modules/TensorMechanics/Master/index.md'
-    requirement = 'The TensorMechanics MasterAction shall calculate the elastic stress and strain response for a 3D pressurized hollow cylinder with a large strain incremental strain formulation using AD.'
-  [../]
-  [./ad-axisym_resid]
-    type = Exodiff
-    input = 'ad-2D-RZ_finiteStrain_resid.i'
-    exodiff = 'ad-2D-RZ_finiteStrain_resid_out.e'
-    use_old_floor = true
-    abs_zero = 1e-8
-    compiler = 'GCC CLANG'
-    design = 'source/materials/ADComputeAxisymmetricRZFiniteStrain.md'
-    requirement = 'The ADComputeAxisymmetricRZFiniteStrain class shall compute the reaction forces on the top surface of a cylinder which is loaded axially in tension.'
-  [../]
-  [./ad-axisym_resid_Bbar]
-    type = Exodiff
-    input = 'ad-2D-RZ_finiteStrain_resid.i'
-    exodiff = 'ad-2D-RZ_finiteStrain_resid_bbar_out.e'
-    use_old_floor = true
-    abs_zero = 1e-8
-    compiler = 'GCC CLANG'
-    cli_args = 'GlobalParams/volumetric_locking_correction=true Outputs/file_base=ad-2D-RZ_finiteStrain_resid_bbar_out'
-    prereq = 'ad-axisym_resid'
-    design = 'source/materials/ADComputeAxisymmetricRZFiniteStrain.md VolumetricLocking.md'
-    requirement = 'The ADComputeAxisymmetricRZFiniteStrain class shall compute the reaction forces on the top surface of a cylinder which is loaded axially in tension when using the B-bar volumetric locking correction.'
-  [../]
-  [./ad-axisymmetric_vlc_centerline_pp]
-    type = CSVDiff
-    input = 'ad-2D-RZ_centerline_VLC.i'
-    csvdiff = 'ad-2D-RZ_centerline_VLC_out.csv'
-    design = 'VolumetricLocking.md source/postprocessors/AxisymmetricCenterlineAverageValue.md'
-    issues = '#12437 #10866'
-    requirement  = 'The volumetric locking correction option in ADComputeAxisymmetricRZFiniteStrain shall reinit material properties without inverting a zero tensor when called from a side postprocessor applied to the axis of rotation in an axisymmetric simulation.'
-  [../]
-
-  [./ad-axisym_smallstrain-jac]
-    type = PetscJacobianTester
-    input = 'ad-2D-RZ_test.i'
-    cli_args = 'Modules/TensorMechanics/Master/all/incremental=false
-    Materials/stress/type=ADComputeLinearElasticStress'
-    run_sim = 'True'
-    ratio_tol = 5e-8
-    difference_tol = 1e7
-    petsc_version = '>=3.9.4'
-    issues = '#12650'
-    design = 'jacobian_definitions.md'
-    requirement = 'The ADComputeAxisymmetricRZSmallStrain class shall compute the mechanical response for a pressurized hollow cylinder with a small total axisymmetric strain formulation and shall produce perfect jacobians.'
-  [../]
-  [./ad-axisym_incremental_strain-jac]
-    type = PetscJacobianTester
-    input = 'ad-2D-RZ_test.i'
-    cli_args = 'Modules/TensorMechanics/Master/all/incremental=true
-                Materials/stress/type=ADComputeFiniteStrainElasticStress'
-    run_sim = 'True'
-    ratio_tol = 5e-8
-    difference_tol = 1e7
-    petsc_version = '>=3.9.4'
-    issues = '#12650'
-    design = 'jacobian_definitions.md'
-    requirement = 'The ADComputeAxisymmetricRZIncrementalStrain class shall compute the mechanical response for a pressurized hollow cylinder with a small incremental axisymmetric strain formulation and shall produce perfect jacobians.'
-  [../]
-  [./ad-axisym_finitestrain-jac]
-    type = PetscJacobianTester
-    input = 'ad-2D-RZ_finiteStrain_test.i'
-    run_sim = 'True'
-    ratio_tol = 5e-8
-    difference_tol = 1e7
-    petsc_version = '>=3.9.4'
-    issues = '#12650'
-    design = 'jacobian_definitions.md'
-    requirement = 'The ADComputeAxisymmetricRZFiniteStrain class shall compute the mechanical response for a pressurized hollow cylinder with a small incremental axisymmetric strain formulation and shall produce perfect jacobians.'
-  [../]
-  [./ad-3D_RZ_finitestrain-jac]
-    type = PetscJacobianTester
-    input = 'ad-3D-RZ_finiteStrain_test.i'
-    valgrind = 'HEAVY'
-    skip = 'Exceeds AD_MAX_DOFS_PER_ELEM'
-    heavy = true
-    run_sim = 'True'
-    ratio_tol = 1e-8
-    difference_tol = 1e-8
-    petsc_version = '>=3.9.4'
-    issues = '#12650'
-    design = 'jacobian_definitions.md'
-    requirement = 'The TensorMechanics MasterAction shall calculate the elastic stress and strain response for a 3D pressurized hollow cylinder with a large strain incremental strain formulation with AD and shall produce perfect jacobians.'
-  [../]
-  [./ad-axisym_resid-jac]
-    type = PetscJacobianTester
-    input = 'ad-2D-RZ_finiteStrain_resid.i'
-    compiler = 'GCC CLANG'
-    run_sim = 'True'
-    ratio_tol = 1e-8
-    difference_tol = 1e-8
-    petsc_version = '>=3.9.4'
-    issues = '#12650'
-    design = 'jacobian_definitions.md'
-    requirement = 'The ADComputeAxisymmetricRZFiniteStrain class shall compute the reaction forces on the top surface of a cylinder which is loaded axially in tension and shall produce perfect jacobians.'
-  [../]
-  [./ad-axisym_resid_Bbar-jac]
-    type = PetscJacobianTester
-    input = 'ad-2D-RZ_finiteStrain_resid.i'
-    compiler = 'GCC CLANG'
-    cli_args = 'GlobalParams/volumetric_locking_correction=true'
-    run_sim = 'True'
-    ratio_tol = 1e-8
-    difference_tol = 1e-8
-    petsc_version = '>=3.9.4'
-    issues = '#12650'
-    design = 'jacobian_definitions.md'
-    requirement = 'The ADComputeAxisymmetricRZFiniteStrain class shall compute the reaction forces on the top surface of a cylinder which is loaded axially in tension when using the B-bar volumetric locking correction and shall produce perfect jacobians.'
-  [../]
-  [./ad-axisymmetric_vlc_centerline_pp-jac]
-    type = PetscJacobianTester
-    input = 'ad-2D-RZ_centerline_VLC.i'
-    cli_args = "Outputs/active=''"
-    run_sim = 'True'
-    ratio_tol = 1e-8
-    difference_tol = 1e-8
-    petsc_version = '>=3.9.4'
-    issues = '#12650'
-    design = 'jacobian_definitions.md'
-    requirement  = 'The volumetric locking correction option in ADComputeAxisymmetricRZFiniteStrain shall reinit material properties without inverting a zero tensor when called from a side postprocessor applied to the axis of rotation in an axisymmetric simulation and shall produce perfect jacobians.'
-  [../]
 []

modules/tensor_mechanics/test/tests/ad_1D_spherical/gold/finiteStrain_1DSphere_hollow_out.e

@@ -0,0 +1 @@
+../../1D_spherical/gold/finiteStrain_1DSphere_hollow_out.e

modules/tensor_mechanics/test/tests/ad_1D_spherical/gold/smallStrain_1DSphere_out.e

@@ -0,0 +1 @@
+../../1D_spherical/gold/smallStrain_1DSphere_out.e

modules/tensor_mechanics/test/tests/ad_1D_spherical/tests

@@ -0,0 +1,69 @@
+[Tests]
+  [./smallStrain_1DSphere]
+    type = Exodiff
+    input = 'smallStrain_1DSphere.i'
+    exodiff = 'smallStrain_1DSphere_out.e'
+    compiler = 'CLANG GCC'
+    cli_args = 'Modules/TensorMechanics/Master/all/incremental=false
+                Materials/stress/type=ADComputeLinearElasticStress'
+    issues = '#6256 #7555'
+    design = 'source/Materials/ComputeRSphericalSmallStrain.md source/Materials/stress/ComputeLinearElasticStress.md syntax/Modules/TensorMechanics/Master/index.md'
+    requirement = 'The ComputeRSphericalSmallStrain class, called through the TensorMechanicsMaster action, shall compute the total linearized solution for the displacement of a solid isotropic elastic sphere with a pressure applied to the outer surface using a 1D spherical symmetric formulation with total small strain assumptions.'
+  [../]
+  [./smallStrain_1DSphere_incremental]
+    type = Exodiff
+    input = 'smallStrain_1DSphere.i'
+    exodiff = 'smallStrain_1DSphere_out.e'
+    compiler = 'CLANG GCC'
+    cli_args = 'Modules/TensorMechanics/Master/all/incremental=true
+                Materials/stress/type=ADComputeFiniteStrainElasticStress'
+    prereq = 'smallStrain_1DSphere'
+    issues = '#6256 #7555'
+    design = 'source/Materials/ComputeRSphericalIncrementalStrain.md source/Materials/stress/ComputeFiniteStrainElasticStress.md syntax/Modules/TensorMechanics/Master/index.md'
+    requirement = 'The ComputeRSphericalIncrementalStrain class, called through the TensorMechanicsMaster action, shall find the linearized incremental strain displacement of a solid isotropic elastic sphere with a pressure applied to the outer surface using a 1D spherical symmetric formulation with incremental small strain assumptions.'
+  [../]
+  [./finiteStrain_1DSphere_hollow]
+    type = Exodiff
+    input = 'finiteStrain_1DSphere_hollow.i'
+    exodiff = 'finiteStrain_1DSphere_hollow_out.e'
+    compiler = 'CLANG GCC'
+    issues = '#6256 #7555'
+    design = 'source/Materials/ComputeRSphericalFStrain.md source/Materials/stress/ComputeFiniteStrainElasticStress.md syntax/Modules/TensorMechanics/Master/index.md'
+    requirement = 'The ComputeRSphericalFiniteStrain class, called through the TensorMechanicsMaster action, shall find the finite incremental strain displacement of a thick walled hollow isotropic elastic sphere under an applied load using a 1D spherical symmetric fomulation with incremental finite strain assumptions.'
+  [../]
+
+  [./smallStrain_1DSphere-jac]
+    type = 'PetscJacobianTester'
+    input = 'smallStrain_1DSphere.i'
+    run_sim = 'True'
+    difference_tol = 1e-5
+    petsc_version = '>=3.9.4'
+    cli_args = 'Modules/TensorMechanics/Master/all/incremental=false
+                Materials/stress/type=ADComputeLinearElasticStress'
+    issues = '#12650'
+    design = 'jacobian_definitions.md'
+    requirement = 'The Jacobian for the AD small strain elasticity problem with Pressure BC in spherical coordinates shall be perfect'
+  [../]
+  [./smallStrain_1DSphere_incremental-jac]
+    type = 'PetscJacobianTester'
+    input = 'smallStrain_1DSphere.i'
+    run_sim = 'True'
+    difference_tol = 1e-5
+    petsc_version = '>=3.9.4'
+    cli_args = 'Modules/TensorMechanics/Master/all/incremental=true
+                Materials/stress/type=ADComputeFiniteStrainElasticStress'
+    issues = '#12650'
+    design = 'jacobian_definitions.md'
+    requirement = 'The Jacobian for the AD small incremental strain elasticity problem with Pressure BC in spherical coordinates shall be perfect'
+  [../]
+  [./finiteStrain_1DSphere_hollow-jac]
+    type = 'PetscJacobianTester'
+    input = 'finiteStrain_1DSphere_hollow.i'
+    run_sim = 'True'
+    difference_tol = 1
+    petsc_version = '>=3.9.4'
+    issues = '#12650'
+    design = 'jacobian_definitions.md'
+    requirement = 'The Jacobian for the AD small incremental strain elasticity problem with Pressure BC in spherical coordinates shall be perfect'
+  [../]
+[]

modules/tensor_mechanics/test/tests/ad_2D_geometries/gold/2D-RZ_centerline_VLC_out.csv

@@ -0,0 +1 @@
+../../2D_geometries/gold/2D-RZ_centerline_VLC_out.csv

modules/tensor_mechanics/test/tests/ad_2D_geometries/gold/2D-RZ_finiteStrain_resid_bbar_out.e

@@ -0,0 +1 @@
+../../2D_geometries/gold/2D-RZ_finiteStrain_resid_bbar_out.e

modules/tensor_mechanics/test/tests/ad_2D_geometries/gold/2D-RZ_finiteStrain_resid_out.e

@@ -0,0 +1 @@
+../../2D_geometries/gold/2D-RZ_finiteStrain_resid_out.e

modules/tensor_mechanics/test/tests/ad_2D_geometries/gold/2D-RZ_finiteStrain_test_out.e

@@ -0,0 +1 @@
+../../2D_geometries/gold/2D-RZ_finiteStrain_test_out.e

modules/tensor_mechanics/test/tests/ad_2D_geometries/gold/2D-RZ_incremental_strain_bbar_test_out.e

@@ -0,0 +1 @@
+../../2D_geometries/gold/2D-RZ_incremental_strain_bbar_test_out.e