Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a login verification login check and suppress some exit errors (Fixes #5) #10

Merged
merged 6 commits into from
May 8, 2020

Conversation

vincentheet
Copy link
Collaborator

A login verification check is added to verify if the login is successful and the correct role can be assumed. Due to these extra checks we can safely ignore an exit error from puppeteer which resolves issue #5 .

Copy link
Contributor

@jonathanjuursema jonathanjuursema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanjuursema jonathanjuursema changed the title Added a login verification login check and suppress some exit errors Added a login verification login check and suppress some exit errors (Fixes #5) May 4, 2020
@vincentheet vincentheet merged commit f9c8587 into master May 8, 2020
@vincentheet vincentheet deleted the false-login-error branch February 15, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants