Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magisk manager unable to detect installed magisk on " 43c1105d "... #4005

Closed
Haus3master opened this issue Mar 9, 2021 · 13 comments
Closed
Labels
regression Something works in previous versions but not in the current one

Comments

@Haus3master
Copy link

Haus3master commented Mar 9, 2021

Hello,
I'm on magisk canary version " 43c1105 " and after the device is rebooted after the update, none of my arm64 devices recognized the magisk installation, upon opening the app after the reboot the apps gives a popup shown in the image below, and there is no way to bypass this,
and by hitting on 'install' it installs the manager but then, the manager no longer recognizes the installed magisk and this is a screenshot proving it...
Screenshot_20210309-180942
and by hitting on installs it installs the manager but then, the manager no longer recognizes the installed magisk and this is a screenshot proving it...
Screenshot_20210309-181822
This is happening on the lenovo tb-8504x and moto G5s and they both have arm64-v8a processor, phones with 32 bit chips are unaffected so far...
Edit: Just to clarify, magiskhide and all the modules do load from the previous version, only the manager isn't detecting the installation, apps that were previously granted root access still have them, but, there is no way to give an app fresh permission to root access...
Edit 2: I'm not sure about which logs from when are needed to be uploaded here, so, if any logs are required, I'm ready to provide them...
Device:Lenovo TB-8504x and Moto G5s Montana
Android version: Android 9 on both devices (Lineage os on the lenovo and pixel experience on the Motorola)
Magisk version name: " 43c1105 "
Magisk version code: 22004

@github-actions

This comment has been minimized.

@github-actions github-actions bot closed this as completed Mar 9, 2021
@vvb2060 vvb2060 reopened this Mar 9, 2021
@vvb2060

This comment has been minimized.

@Haus3master

This comment has been minimized.

@Didgeridoohan
Copy link
Contributor

I've got the same thing on my OP3T (also arm64) running an Android 9 ROM (ArrowOS). Gonna try to grab some logs later, but it doesn't seem like 22004 is saving a Magisk log for me...

@Haus3master
Copy link
Author

Haus3master commented Mar 9, 2021

I've got the same thing on my OP3T (also arm64) running an Android 9 ROM (ArrowOS). Gonna try to grab some logs later, but it doesn't seem like 22004 is saving a Magisk log for me...

No, it is not able to save any magisk logs, and since I haven't granted root access to the "Shell" package, I'm plain out of luck..., so, please post your logs here...
Edit: Also, what logs should I post? I will try getting them in some form or the other...

@logickoder
Copy link

I'm facing this same problem, I'm using magisk canary 22004 and it doesn't show root even though I flashed the patched boot image, it all started when I updated my magisk manager to version 22

@Didgeridoohan
Copy link
Contributor

Well, the Magisk log doesn't get saved on 22004, but it runs... Attaching a boot logcat (where you can see the Magisk log as well) and a logcat when opening the Magisk app. No idea if they show anything...

boot.log
Magisk_22004_NA.txt

@osm0sis osm0sis added the regression Something works in previous versions but not in the current one label Mar 11, 2021
@aIecxs
Copy link

aIecxs commented Mar 12, 2021

this is probably usage problem - please try and report back
https://android.stackexchange.com/q/231184

@Didgeridoohan
Copy link
Contributor

this is probably usage problem - please try and report back
https://android.stackexchange.com/q/231184

Yes, that would be a great solution (and a common problem for this issue). But, I didn't have the app hidden when updating...

And installing app build 22003 makes it recognise the installed 22004 binaries, but updating to app 22004 changes the installed status to N/A again. Which I just now realised is information I haven't shared previously...

@AndrewKvas
Copy link

Me too magisk manager unable to detect installed magisk on "43c1105d".
Android 8.0.0

shakalaca added a commit to shakalaca/Magisk that referenced this issue Mar 12, 2021
* There will be garbage output when executing `su` (topjohnwu#4016)
* Failed to check root status and showing N/A in status (topjohnwu#4005)

Signed-off-by: Shaka Huang <shakalaca@gmail.com>
@Didgeridoohan
Copy link
Contributor

And installing app build 22003 makes it recognise the installed 22004 binaries, but updating to app 22004 changes the installed status to N/A again. Which I just now realised is information I haven't shared previously...

Apparently this was some kind of weird fluke and I have not been able to reproduce a working setup with app 22003 since...

But, I can confirm the commit above fixes it.

@Haus3master
Copy link
Author

And installing app build 22003 makes it recognise the installed 22004 binaries, but updating to app 22004 changes the installed status to N/A again. Which I just now realised is information I haven't shared previously...

Apparently this was some kind of weird fluke and I have not been able to reproduce a working setup with app 22003 since...

But, I can confirm the commit above fixes it.

Then, on that note, we just have to wait a bit for the owner to release a canary update...

topjohnwu pushed a commit to shakalaca/Magisk that referenced this issue Mar 14, 2021
* There will be garbage output when executing `su` (topjohnwu#4016)
* Failed to check root status and showing N/A in status (topjohnwu#4005)

Signed-off-by: Shaka Huang <shakalaca@gmail.com>
topjohnwu pushed a commit that referenced this issue Mar 14, 2021
* There will be garbage output when executing `su` (#4016)
* Failed to check root status and showing N/A in status (#4005)

Signed-off-by: Shaka Huang <shakalaca@gmail.com>
@Haus3master
Copy link
Author

Did a new canary update come out as of now?

kubalav pushed a commit to kubalav/Magisk that referenced this issue Sep 13, 2021
* There will be garbage output when executing `su` (topjohnwu#4016)
* Failed to check root status and showing N/A in status (topjohnwu#4005)

Signed-off-by: Shaka Huang <shakalaca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Something works in previous versions but not in the current one
Projects
None yet
Development

No branches or pull requests

8 participants