Fix fd sanitization #7464
Closed
Fix fd sanitization #7464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix broken logic introduced by commit 79a1c39 which modify `fds_to_ignore` when `android_log_close` is called, where `fds_to_ignore` was already read and converted into a C++ vector, so our hacks never take effect. This fixes topjohnwu#7448 - The previous logic rely on `android_log_close` to close `logd_fd` in zygote and causes `logd_fd` being closed and re-acquired too many times. Update `fds_to_ignore` in zygote process as well to avoid that case.
|
No issues with this build🎉 |
|
I think this PR is superseeded from this commit 489100c |
|
Included in 489100c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fds_to_ignorewhenandroid_log_closeis called, wherefds_to_ignorewas already read and converted into a C++ vector, so our hacks never take effect. This fixes Zygisk's FD sanitization broken on 26302 #7448android_log_closeto closelogd_fdin zygote and causeslogd_fdbeing closed and re-acquired too many times. Updatefds_to_ignorein zygote process as well to avoid that case.