OAUTH2-207 Add Feature to register CORS Filter #691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xecute after AuthVerifierFilter
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
martamedio
changed the title
csierra
reviewed
Jan 25, 2019
...-provider-rest/src/main/java/com/liferay/oauth2/provider/rest/internal/cors/CORSFeature.java
Show resolved
Hide resolved
|
ci:test:sf |
liferay-continuous-integration
added
ci:test:sf - pending
ci:test:sf - failure
and removed
ci:test:sf - pending
labels
❌ ci:test:sf - 0 out of 1 jobs passed in 1 minute 31 seconds 204 msClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: OAUTH2-207 1 Failed Jobs:For more details click here.Please fix rebase errors on martamedio/OAUTH2-207 |
|
Closing CORS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have added a Feature to register CORS Filter as we discussed.
cc/ @csierra
Edited: We have also studied the possibility of not implementing a Feature and using a ContainerRequestFilter/ContainterResponseFilter, but involves some changes to avoid code duplication (for parsing headers and get the OAuth2 application).
So far I have left it with the Feature format, we look forward to your comments.