Skip to content

Commit

Permalink
chore: pr comments
Browse files Browse the repository at this point in the history
Signed-off-by: Jakob Möller <jmoller@redhat.com>
  • Loading branch information
jakobmoellerdev committed Apr 30, 2024
1 parent 51d0ca5 commit 8cfee62
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion internal/driver/internal/k8s/logicalvolume_service.go
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ func (s *LogicalVolumeService) DeleteVolume(ctx context.Context, volumeID string
return true, nil
}
logger.Error(err, "failed to get LogicalVolume", "name", lv.Name)
return false, nil
return false, err
}
logger.Info("waiting for LogicalVolume to be deleted", "name", lv.Name)
return false, nil
Expand Down
1 change: 1 addition & 0 deletions internal/driver/node.go
Original file line number Diff line number Diff line change
Expand Up @@ -534,6 +534,7 @@ func (s *nodeServerNoLocked) NodeExpandVolume(ctx context.Context, req *csi.Node
}

logger.Info("NodeExpandVolume(fs) is succeeded")

// `capacity_bytes` in NodeExpandVolumeResponse is defined as OPTIONAL.
// If this field needs to be filled, the value should be equal to `.status.currentSize` of the corresponding
// `LogicalVolume`, but currently the node plugin does not have an access to the resource.
Expand Down

0 comments on commit 8cfee62

Please sign in to comment.