Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Introduction to creating a PR to topolvm #893

Closed
guettli opened this issue Apr 22, 2024 · 2 comments
Closed

Docs: Introduction to creating a PR to topolvm #893

guettli opened this issue Apr 22, 2024 · 2 comments
Labels

Comments

@guettli
Copy link
Contributor

guettli commented Apr 22, 2024

What should the feature do:

I would like to see some documentation, about how to create a PR for topolvm.

Other projects use tools like Tilt.

How do you develop the Go code. I run make multi-platform-image-normal which takes ~60 seconds even if no code was changed.

I guess you use some other workflow to modify the source code (and test it in a cluster).

What is use case behind this feature:

I want to enhance topolvm.

@llamerada-jp
Copy link
Contributor

There is a contribution guide, but it may be out of date. If you try it and find anything wrong, I would be happy to have it pointed out.
https://github.com/topolvm/topolvm/blob/main/CONTRIBUTING.md

We have tried to introduce tilt before and it was abandoned. It may be helpful to you.
#405
#434

@guettli
Copy link
Contributor Author

guettli commented Apr 25, 2024

@llamerada-jp thank you for your reply. I have seen that topolvm has many envTests. I like that! This way I can test my code easily, and I don't need to build a container and upload it into a cluster often.

For me Tilt is handy, when I need to develop something in a running dev cluster (for example bare-metal).

Because of the good test coverage, Tilt is not needed for me here. The contribution page is all I need.

Thank you for your reply.

@guettli guettli closed this as completed Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

2 participants