Restart csi-registrar if registration is failed. #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, csi-registrar failed to register topolvm into kubelet due to lost connection. In theory, the connection loss can be handled by grpc library automatically, but it does not work by some kind of bugs. We use livenessProbe to restart csi-regisrar instead. The functionality to detect the case is introduced as of v2.3.0, the version depends on kubernetes 1.20 or higher, which is higher than our minimum supported version 1.19. I think it is ok because the plugin registration system does not change.
toshipp
requested review from
a team,
cupnes,
satoru-takeuchi and
llamerada-jp
and removed request for
a team and
satoru-takeuchi
|
upstream issue: kubernetes-csi/node-driver-registrar#139 |
|
MEMO: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, csi-registrar failed to register topolvm into kubelet due to lost
connection. In theory, the connection loss can be handled by grpc library
automatically, but it does not work by some kind of bugs. We use
livenessProbe to restart csi-regisrar instead. The functionality to detect
the case is introduced as of v2.3.0, the version depends on kubernetes
1.20 or higher, which is higher than our minimum supported version 1.19.
I think it is ok because the plugin registration system does not change.