Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documents #786

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Update documents #786

merged 1 commit into from
Dec 18, 2023

Conversation

toshipp
Copy link
Contributor

@toshipp toshipp commented Nov 20, 2023

@toshipp toshipp changed the title Doc Update documents Nov 30, 2023
toshipp
toshipp commented Nov 30, 2023
View reviewed changes
docs/advanced-setup.md
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is based on deploy/README.md and user-manual.md

toshipp
toshipp commented Nov 30, 2023
View reviewed changes
docs/faq.md Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contents are staled and moved to other appropriate places.

toshipp
toshipp commented Nov 30, 2023
View reviewed changes
docs/node-maintenance.md Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is based on user-manual.md

@toshipp toshipp marked this pull request as ready for review November 30, 2023 11:38
@toshipp toshipp requested a review from a team as a code owner November 30, 2023 11:38
peng225
peng225 reviewed Dec 1, 2023
View reviewed changes
Copy link
Contributor

@peng225 peng225 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments so far.
I will continue my review. (Currently about 40% done.)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/topolvm-controller.md Outdated Show resolved Hide resolved
docs/topolvm-controller.md Outdated Show resolved Hide resolved
docs/maintenance.md Outdated Show resolved Hide resolved
docs/lvmd.md Outdated Show resolved Hide resolved
docs/lvmd.md Outdated Show resolved Hide resolved
peng225
peng225 reviewed Dec 4, 2023
View reviewed changes
Copy link
Contributor

@peng225 peng225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will continue my review. (Currently about 40% done.)

I finished my initial review.

docs/README.md Show resolved Hide resolved
docs/lvmd.md Outdated Show resolved Hide resolved
docs/limitations.md Outdated Show resolved Hide resolved
docs/limitations.md Outdated Show resolved Hide resolved
docs/advanced-setup.md Outdated Show resolved Hide resolved
docs/advanced-setup.md Show resolved Hide resolved
docs/advanced-setup.md Outdated Show resolved Hide resolved
docs/advanced-setup.md Outdated Show resolved Hide resolved
docs/advanced-setup.md Outdated Show resolved Hide resolved
docs/advanced-setup.md Outdated Show resolved Hide resolved
@toshipp toshipp requested a review from peng225 December 7, 2023 10:22
peng225
peng225 previously approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@peng225 peng225 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM. I can approve it after you fix my last comment and rebase the branch.
(I approved by mistake...)

README.md Outdated Show resolved Hide resolved
@peng225 peng225 self-requested a review December 11, 2023 04:55
peng225
peng225 previously approved these changes Dec 12, 2023
View reviewed changes
pluser
pluser reviewed Dec 12, 2023
View reviewed changes
docs/advanced-setup.md Outdated Show resolved Hide resolved
docs/advanced-setup.md Outdated Show resolved Hide resolved
docs/advanced-setup.md Outdated Show resolved Hide resolved
@toshipp
Copy link
Contributor Author

toshipp commented Dec 13, 2023

@pluser
Thank you for your review. I updated them as you recommended.

pluser
pluser previously approved these changes Dec 14, 2023
View reviewed changes
peng225
peng225 reviewed Dec 15, 2023
View reviewed changes
docs/advanced-setup.md Outdated Show resolved Hide resolved
@toshipp
Update documents
0bd0dc4 
Update documents to reflect latest TopoLVM behavior. Also reduce
redundant text and re-organize these to make it easier to read them by
users.

Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
@pluser pluser merged commit 83dbe85 into main Dec 18, 2023
26 checks passed
@pluser pluser deleted the doc branch December 18, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pluser pluser pluser approved these changes

@peng225 peng225 peng225 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update staled documents
3 participants
@toshipp @pluser @peng225