Reduce duplicated contents #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toshipp
force-pushed
the
improve-test
branch
7 times, most recently
from
8ecf0c7
to
a92893b
Compare
Previously, helm values files were prepared for each test, so the contents were duplicated. Duplication was eliminated by dividing the file by the required function. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
kubernetes does not require specifying fsType in SC, we follow it in our helm chart. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
kubernetes accepts the field in SC, we follow it. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
toshipp
force-pushed
the
improve-test
branch
2 times, most recently
from
d64c8fc
to
f2a7a70
Compare
Since TopoLVM uses its domain name for key names in StorageClass parameter, it is nice to use directives. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
StorageClasses were defined in not only the helm values file but also provisioner.yaml. To ease maintenability, put them all in the values file. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
Now it has only VolumeSnapshotClass, rename it. Also dedup the legacy variant by using sed. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
toshipp
force-pushed
the
improve-test
branch
from
a1cb0fb
to
4297868
Compare
toshipp
requested review from
daichimukai,
satoru-takeuchi and
peng225
and removed request for
daichimukai
peng225
reviewed
Dec 26, 2023
peng225
approved these changes
Dec 26, 2023
satoru-takeuchi
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many duplicated contents, but they can be reduced by helm functionality.