-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid using cybozu-go/well #798
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llamerada-jp
requested changes
Dec 27, 2023
ushitora-anqou
force-pushed
the
dont-use-cybozu-go-well
branch
2 times, most recently
from
January 5, 2024 01:57
d8b719f
to
711bbff
Compare
Changes that I made after llamerada-jp's review: |
llamerada-jp
requested changes
Jan 5, 2024
ushitora-anqou
force-pushed
the
dont-use-cybozu-go-well
branch
from
January 9, 2024 00:28
711bbff
to
e9a0ff1
Compare
llamerada-jp
requested changes
Jan 9, 2024
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
ushitora-anqou
force-pushed
the
dont-use-cybozu-go-well
branch
2 times, most recently
from
January 9, 2024 05:08
ae2be29
to
cc0be51
Compare
ushitora-anqou
force-pushed
the
dont-use-cybozu-go-well
branch
from
January 10, 2024 04:53
cc0be51
to
0684eb2
Compare
llamerada-jp
previously approved these changes
Jan 10, 2024
daichimukai
reviewed
Jan 11, 2024
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
ushitora-anqou
force-pushed
the
dont-use-cybozu-go-well
branch
from
January 12, 2024 08:34
0684eb2
to
6c6bf8c
Compare
daichimukai
reviewed
Jan 15, 2024
daichimukai
approved these changes
Jan 15, 2024
llamerada-jp
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TopoLVM is using cybozu-go/well, but it's now deprecated. This patch makes TopoLVM avoid using cybozu-go/well.