Don't abuse daemonset env condition #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we check if daemonset LVMd is used by the environment variable. But if so, the configuration exists as the CM, we omit the check. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
The requirement to schedule a pod at the node where the PVC exists still applies when using storage capacity. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
When using daemonset LVMd, we use minikube. In the environment, there are no multiple nodes and we enable storage capacity tracking feature. The previous code abused the condition whether daemonset LVMd is used to express such conditions, we now split it to make the code more readable. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
It is related to node count rather than using daemonset LVMd. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
When using daemonset LVMd, kindnet is not deployed in the environment because we use minikube. However, it is not related, moreover, we can check if waiting it by its existence. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
cupnes
reviewed
Jan 10, 2024
We discovered that control plane nodes possess varying values for the node-role.kubernetes.io/control-plane label across different environments. The document[1] do not provide any information regarding the value. Therefore, alter the expression to test only the key. [1]: https://kubernetes.io/docs/reference/labels-annotations-taints/#node-role-kubernetes-io-control-plane Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
llamerada-jp
approved these changes
Jan 10, 2024
cupnes
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code used daemonset env condition in many places, but it did not directly express the meaning.
In this PR, change the condition or remove it to make it more readable.