Change VG names for readability #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the dc3 device-class was defined for DS LVMd, but not for the systemd-service LVMd, except on node3. This was because we wanted to schedule a pod using dc3 on a specific node to simplify the writing of tests. However, since this can be achieved using nodeSelector, we can now remove dc3 and synchronize the LVMd configuration. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
We used different names in the kind and minikube environments. But it is not a technical requirement, we should use same names to improve readability. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
The previous names are too agnostic. To make them easier to understand, change their names according to their characters. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
toshipp
commented
Jan 12, 2024
| @@ -105,7 +102,7 @@ func testThinProvisioning() { | |||
| By("deploying multiple PVCS with total size < thinpoolsize * overprovisioning") | |||
| // The actual thinpool size is 4 GB . With an overprovisioning limit of 5, it should allow | |||
| // PVCs totalling upto 20 GB for each node | |||
| nodeName := "topolvm-e2e-worker2" | |||
| nodeName := "topolvm-e2e-worker" | |||
There was a problem hiding this comment.
We create a namespace for each It and delete the namespace after the spec of the It ends. Therefore, it is ok to use the same node.
toshipp
commented
Jan 12, 2024
| @@ -191,7 +185,7 @@ func testThinProvisioning() { | |||
| It("should check overprovision limits", func() { | |||
| By("Deploying a PVC to use up the available thinpoolsize * overprovisioning") | |||
|
|
|||
| nodeName := "topolvm-e2e-worker3" | |||
| nodeName := "topolvm-e2e-worker" | |||
satoru-takeuchi
approved these changes
Jan 12, 2024
daichimukai
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used different VG names on kind and minikube and the names are too agnostic, so it is hard to maintain. This PR assigns readable names and use same names on both kind and minikube.