Remove declaration of port 9808 from the livenessprobe container #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gmarcy Hi. Could you sign your commit by adding |
…ainer Signed-off-by: Glenn Marcy <homelab@glenn4u.com>
gmarcy
force-pushed
the
livenessprobe_fix
branch
from
2fe7c5a
to
1b062db
Compare
I've amended the commit with the Signed-off-by field |
ushitora-anqou
previously approved these changes
Jan 12, 2024
|
@gmarcy I'm afraid that I found another place to fix after my approval. These lines should be removed for the same reason. Could you update your commit? |
Signed-off-by: Glenn Marcy <homelab@glenn4u.com>
Done |
pluser
approved these changes
Jan 15, 2024
ushitora-anqou
approved these changes
Jan 16, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the guidance of the livenessprobe repo, the port should be declared only on the controller.