feat: add "additionalVolumes" for lvmd and node ds

[ryanfaircloth]

Additional volumes simplifies configuration for init pods in the data sets by allowing additional volumes without changing the required topolvm volumes

[pluser]

Is there a commit (67bc915) unrelated to this PR in the mix?

[ryanfaircloth]

Unrelated this or will let me add an init container to setup the vg but I added the nodepid as configurable with the same default just in case that becomes important

…

On Mon, Jan 15, 2024 at 1:38 AM ESASHIKA Kaoru ***@***.***> wrote: Is there a commit (67bc915 <67bc915>) unrelated to this PR in the mix? — Reply to this email directly, view it on GitHub <#814 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIN6WOFJ26ANLXOAHZ7PKZTYOTFGBAVCNFSM6AAAAABB2BTCIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJRGM4TCNJZHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[ryanfaircloth]

Updated I forgot to set he default in values.yaml

[ryanfaircloth]

I believe all requested changes are complete, constructive feedback thank you

[toshipp]

@ryanfaircloth
Thank you for your contribution! LGTM.

[pluser]

Could you please clean up the commit message?
It looks like you are reverting to commits that have not been merged into the master branch.
Once that is resolved, this PR looks fine.

[toshipp]

@ryanfaircloth
Could you check @pluser's message?

[ryanfaircloth]

Could you please clean up the commit message? It looks like you are reverting to commits that have not been merged into the master branch. Once that is resolved, this PR looks fine.

Can you show me what you are referring to happy to fix, what I see as my commit message here

[toshipp]

@ryanfaircloth
Did you check this URL?
03cbb92

What I see is

[ryanfaircloth]

@ryanfaircloth Did you check this URL? 03cbb92

What I see is

Fixed it was a silly issue on my side I used github desktop to amend the message and it was cutting off after the first signoff for future reference I know to watch for that

[toshipp]

@ryanfaircloth
Sorry, I forgot we should run helm-docs to update the chart readme.
Could you do that?
The instructions are following.

make install-helm-docs
./bin/helm-docs

[ryanfaircloth]

@toshipp README updated

[toshipp]

@ryanfaircloth
Could you fix a failure of chart lint?
https://github.com/topolvm/topolvm/pull/814/files#diff-80f31301c246264c6d93fb70fe8700bef090f82dec686d430e06ed2ac7db59d9R182

Also, please rebase it on the main branch to remove the merge commit.

I think there are no other blockers to merge this.

[ryanfaircloth]

@toshipp fixed spaces and rebased

[toshipp]

@ryanfaircloth
I confirmed the lint succeeded.
BTW, other commits not related to PR are introduced. Could you omit them? If it is difficult for you, can I do it instead?

[ryanfaircloth]

Would you please

…

On Wed, Jan 31, 2024 at 8:01 PM FUKAYA Toshikuni ***@***.***> wrote: @ryanfaircloth <https://github.com/ryanfaircloth> I confirmed the lint succeeded. BTW, other commits not related to PR are introduced. Could you omit them? If it is difficult for you, can I do it instead? — Reply to this email directly, view it on GitHub <#814 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIN6WOBN43H4E7MSBV7OZK3YRLSOTAVCNFSM6AAAAABB2BTCIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRQGI3TSMRVGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>