feat: allow disabling leader election in topolvm-controller #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobmoellerdev
force-pushed
the
disabling-leader-election
branch
from
90747d4
to
24fc911
Compare
pluser
reviewed
Jan 16, 2024
Signed-off-by: Jakob Möller <jmoller@redhat.com>
jakobmoellerdev
force-pushed
the
disabling-leader-election
branch
from
24fc911
to
7c39591
Compare
|
LGTM |
pluser
approved these changes
Jan 17, 2024
toshipp
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows disabling leader election for TopoLVM controller. This is important because all sidecars support it and we should offer running TopoLVM in a non-HA controller configuration for CPU/Memory Savings and to avoid surges. This is especially used in the edge context and will not affect existing Helm Charts or Datacenter deployments.
New helm chart version has a new flag for leader election in the controller section that triggers it for topolvm-controller and all sidecars. Flag is set to true by default if omitted.
Also gives an example of a Recreate Deployment strategy that will not impact the controller cache synchronization but is non-HA