doc: state the reason to build csi-sidecars #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We build csi-sidecars in our own. It's convenient for developers to clarify why we do so. Fixes: #822 Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
toshipp
approved these changes
Jan 18, 2024
|
While the reason makes sense on the surface any emergency would likely impact all similar projects equally has this ever occurred is the overhead actually worth the reword. As a counter point I think a more likely issue is conflict with a distro provided side car, aks, eks and open shift all provide their own builds. Redhat does not use the project container ,building their own. While there reason you raise is valid it appears to me to simply be a trade off. As a middle ground the project could build and provide the side cars as independent builds and default to use those images or make that a option selected as part of the deployment |
peng225
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We build csi-sidecars in our own. It's convenient for developers to clarify why we do so.
Fixes: #822