use kubebuilder go/v4 template #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llamerada-jp
force-pushed
the
use-kubebuilder-go-v4-1
branch
2 times, most recently
from
c68d726
to
3d0c797
Compare
peng225
reviewed
Jan 26, 2024
There was a problem hiding this comment.
In this commit message, you say as follows:
And since this project does not use custom
resources, generate-api is not generated either. Therefore, the
related codes are removed.
However, TopoLVM uses LogicalVolume custom resource. Is that OK to remove generate-api target?
llamerada-jp
force-pushed
the
use-kubebuilder-go-v4-1
branch
from
aa9edb1
to
04859b3
Compare
peng225
reviewed
Jan 29, 2024
Signed-off-by: Yuji Ito <llamerada.jp@gmail.com>
Signed-off-by: Yuji Ito <llamerada.jp@gmail.com>
- Since there is a mix of markers with and without space at the head of the comment, it was unified without. Signed-off-by: Yuji Ito <llamerada.jp@gmail.com>
Remove manifests below config, since those are neither used nor maintained. Signed-off-by: Yuji Ito <llamerada.jp@gmail.com>
- Install and run golangci-lint since kubebuilder uses it. - Some rules have been disabled because conflicts with other PRs will occur if all the points currently made are addressed. - The staticcheck built into golangci-lint does not allow to exclude single lines and specific rules, so we disable it and run the existing staticcheck. Signed-off-by: Yuji Ito <llamerada.jp@gmail.com>
llamerada-jp
force-pushed
the
use-kubebuilder-go-v4-1
branch
from
04859b3
to
3cff5a1
Compare
cupnes
approved these changes
Feb 2, 2024
peng225
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update kubebuilder template to go/v4 from go/v3. However, no code is moved to the cmd, internal, and test directories. This would be done in a different PR to avoid conflicts with other PRs. And the resolutions to lint's point will be addressed after the directory move is complete.
a part of: #760