chore: reduce consistent reads per mount to 1 in IsMounted based on kernel version
#832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobmoellerdev
changed the title
IsMounted
|
I'm hesitating to change the number from 3 to 2 because most Kubernetes components seem to adopt 3 or more (link 1, link 2, link 3, and link 4). One of my team members found that this bug in |
|
@ushitora-anqou thanks for the insight! sure that works for me. Anything that is able to reduce these file reads will significantly reduce Allocs / Processor usage for FS based volumes. Regarding the linux check, any preference on how to do that? Otherwise ill just copy and paste from mount utils |
jakobmoellerdev
force-pushed
the
consistent-read-2-times
branch
from
9878027
to
c9f8e1a
Compare
jakobmoellerdev
changed the title
IsMountedIsMounted based on kernel version
|
|
peng225
previously approved these changes
Jan 26, 2024
ushitora-anqou
requested changes
Jan 26, 2024
Signed-off-by: Jakob Möller <jmoller@redhat.com>
jakobmoellerdev
force-pushed
the
consistent-read-2-times
branch
from
c9f8e1a
to
e9083bf
Compare
ushitora-anqou
approved these changes
Jan 26, 2024
|
@peng225 would you mind reapproving again after the header license change? |
peng225
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The consistent read issue reported in #371 has been fixed by doing a consistent read 3 times. This is not necessary as 2 consistent reads will be enough to cover page size timings.
This will severely reduce memory allocations and gc stability during LV creation:
Reasoning:
See a profiling made with 32 PVCs created and allocs collected.