Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add snapshot-and-restore.md #833

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

ushitora-anqou
Copy link
Contributor

Add additional documentation for the Snapshot&Restore functionality. Derived from #827

@ushitora-anqou ushitora-anqou force-pushed the docs/snapshot-and-restore branch 2 times, most recently from a5187de to 70f6df6 Compare January 29, 2024 02:48
@ushitora-anqou ushitora-anqou changed the title [WIP] docs: add snapshot-and-restore.md docs: add snapshot-and-restore.md Jan 29, 2024
@ushitora-anqou ushitora-anqou marked this pull request as ready for review January 29, 2024 09:00
@ushitora-anqou ushitora-anqou requested a review from a team as a code owner January 29, 2024 09:00
Copy link
Contributor

@daichimukai daichimukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

docs/snapshot-and-restore.md Show resolved Hide resolved
@toshipp
Copy link
Contributor

toshipp commented Jan 30, 2024

Please update README.md
https://github.com/topolvm/topolvm/blob/main/docs/README.md

IMO, it should be in the getting started section.

@toshipp
Copy link
Contributor

toshipp commented Jan 30, 2024

also, this could be deleted.
https://github.com/topolvm/topolvm/blob/main/docs/advanced-setup.md#snapshot

Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
@ushitora-anqou
Copy link
Contributor Author

Thanks to the comments by @toshipp and @daichimukai, I updated my patch. The changes are: https://github.com/topolvm/topolvm/compare/debae299312f8eba2cdbf55fac646628dbd7860d..e3a6e95ffedfae6c1e5372398532f7e604262dd8

@daichimukai daichimukai merged commit 75f45d2 into main Feb 1, 2024
8 checks passed
@daichimukai daichimukai deleted the docs/snapshot-and-restore branch February 1, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants