lvmd: fix Watch RPC to notify VG info periodically when embedded #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daichimukai
force-pushed
the
lvmd/fix-watch-rpc-embedded
branch
from
bc5a3b0
to
bb7c415
Compare
The Watch RPC of lvmd's VGService is expected to notify VG information periodically to its watchers. However, when lvmd is embedded into topolvm-node, Watch RPC sends VG info only once on startup time and does nothing after that unless LVService invokes LVM commands for RPCs. This commit addresses the issue. Fixes: c5f17a4 ("feat: implement embed-lvmd") Signed-off-by: Daichi Mukai <daichi-mukai@cybozu.co.jp>
daichimukai
force-pushed
the
lvmd/fix-watch-rpc-embedded
branch
from
bb7c415
to
911cde5
Compare
| @@ -29,6 +31,20 @@ func NewEmbeddedServiceClients(ctx context.Context, dcmapper *DeviceClassManager | |||
| log.FromContext(ctx).Error(err, "embedded channel watch error") | |||
| } | |||
| }() | |||
|
|
|||
| go func() { | |||
| ticker := time.NewTicker(10 * time.Minute) | |||
There was a problem hiding this comment.
Thanks for the fix idea! QQ: How does the regular trigger for notify work on non-embedded mode? Im wondering how its able to do this refresh in the non-embedded mode
There was a problem hiding this comment.
NVM, just found
Lines 105 to 117 in baaea34
Should we extract this into a common method and also make the time interval modifiable now?
There was a problem hiding this comment.
Yes, that's a great idea. But I would like to leave that as a separate task, as my priority is to merge this fix and include it in next month's release.
jakobmoellerdev
approved these changes
Feb 26, 2024
peng225
approved these changes
Feb 27, 2024
cupnes
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Watch RPC of lvmd's VGService is expected to notify VG information periodically to its watchers. However, when lvmd is embedded into topolvm-node, Watch RPC sends VG info only once on startup time and does nothing after that unless LVService invokes LVM commands for RPCs. This commit addresses the issue.
Fixes: c5f17a4 ("feat: implement embed-lvmd")