Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid disk nospace when release workflow #849

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Avoid disk nospace when release workflow #849

merged 2 commits into from
Mar 11, 2024

Conversation

toshipp
Copy link
Contributor

@toshipp toshipp commented Mar 5, 2024

The release workflow failed because of disk no space. see https://github.com/topolvm/topolvm/actions/runs/8137581069/job/22237189098
I doubt actions runner has consumed more disk space than before. To avoid disk exhaustion, use dedicated jobs to build images.

@toshipp toshipp requested a review from a team as a code owner March 5, 2024 08:30
@toshipp toshipp marked this pull request as draft March 5, 2024 08:30
@toshipp toshipp changed the title Avoid disk nospace for release workflow Avoid disk nospace when release workflow Mar 5, 2024
@toshipp
Copy link
Contributor Author

toshipp commented Mar 6, 2024

key: go-${{ hashFiles('go.sum', 'Makefile', 'versions.mk') }}
restore-keys: |
go-
- run: make setup
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted this because tools seem not to be used by other steps.

@toshipp toshipp marked this pull request as ready for review March 6, 2024 08:52
actions/setup-go has the capability.

Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
The release workflow built two multi-platform on the release jobs along
with other release steps. It consumed many disk spaces and the build
failed. To avoid disk exhaustion, use dedicated jobs to build them same
as the main workflow does.

Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
Copy link
Contributor

@daichimukai daichimukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pluser pluser merged commit 5c5a438 into main Mar 11, 2024
24 checks passed
@pluser pluser deleted the avoid-nospace branch March 11, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants