-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid disk nospace when release workflow #849
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toshipp
changed the title
Avoid disk nospace for release workflow
Avoid disk nospace when release workflow
Mar 5, 2024
toshipp
commented
Mar 6, 2024
key: go-${{ hashFiles('go.sum', 'Makefile', 'versions.mk') }} | ||
restore-keys: | | ||
go- | ||
- run: make setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deleted this because tools seem not to be used by other steps.
daichimukai
reviewed
Mar 7, 2024
actions/setup-go has the capability. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
The release workflow built two multi-platform on the release jobs along with other release steps. It consumed many disk spaces and the build failed. To avoid disk exhaustion, use dedicated jobs to build them same as the main workflow does. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
daichimukai
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pluser
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release workflow failed because of disk no space. see https://github.com/topolvm/topolvm/actions/runs/8137581069/job/22237189098
I doubt actions runner has consumed more disk space than before. To avoid disk exhaustion, use dedicated jobs to build images.