fix: use correct ErrNotFound from command package #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ushitora-anqou
requested changes
Mar 25, 2024
There was a problem hiding this comment.
Thank you for fixing this issue!
- Could you update this line too?
- To avoid similar bugs in the future, I'd like to rename one of the definitions. Could you rewrite
lvmd.ErrNotFoundtolvmd.ErrDeviceClassNotFound? I think it is much clearer.
jakobmoellerdev
force-pushed
the
fixup-errnotfound
branch
from
c5dd43a
to
6b4cd7a
Compare
…eClassNotFound Signed-off-by: Jakob Möller <jmoller@redhat.com>
jakobmoellerdev
force-pushed
the
fixup-errnotfound
branch
from
6b4cd7a
to
1e53a92
Compare
pluser
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses the issue reported by #861 where the wrong ErrNotFound Code was used.