Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin setup-envtest to go 1.20 before TopoLVM migrates to go 1.21 #865

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

jakobmoellerdev
Copy link
Contributor

Attempts to temporarily fix #864 by pinning envtest to a version that didnt have the x.y.z syntax

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Signed-off-by: Jakob Möller <jmoller@redhat.com>
Copy link
Contributor

@daichimukai daichimukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @jakobmoellerdev.

@daichimukai daichimukai merged commit ecfadb5 into topolvm:main Mar 27, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Test Regression due to go.mod go x.y.z directive causing errors in go 1.20
3 participants