chore: use exposed controller functions in topolvm controllers #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakob Möller <jmoller@redhat.com>
jakobmoellerdev
force-pushed
the
expose-controller-server-settings
branch
2 times, most recently
from
55c5de7
to
c43b1a6
Compare
toshipp
requested changes
Apr 9, 2024
Signed-off-by: Jakob Möller <jmoller@redhat.com>
jakobmoellerdev
force-pushed
the
expose-controller-server-settings
branch
from
c43b1a6
to
ebfa7d0
Compare
daichimukai
approved these changes
Apr 10, 2024
toshipp
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In retrospect of #875 I noticed that everytime we add a field, we also have to export all embedded fields with it to work correctly outside of the topolvm package. This makes going back and forth for every field extremely tedious.
I thus changed the current command runners in TopoLVM to use the pkg variants of the runners. This will not change any logic (we were already using the same logic just with internal imports) but will let us know via compiler error whenever we have a field change that needs to be exported as well.