fix: use stricter not found matching for lvm calls #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobmoellerdev
force-pushed
the
lvm-error-detection
branch
2 times, most recently
from
8e9b8b3
to
1c8dc35
Compare
jakobmoellerdev
force-pushed
the
lvm-error-detection
branch
from
1c8dc35
to
5fa68b9
Compare
peng225
reviewed
Apr 23, 2024
Signed-off-by: Jakob Möller <jmoller@redhat.com>
jakobmoellerdev
force-pushed
the
lvm-error-detection
branch
from
5fa68b9
to
38d21f2
Compare
peng225
approved these changes
Apr 24, 2024
satoru-takeuchi
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #889 by changing the simple exitcode==5 check to a check that also verifies the returned stderr for the regex
Volume group "(.*?)" not found|Failed to find logical volume "(.*?)so that errors that have exit code 5 but are not about the volume not being present do not cause TopoLVM to ignore the volume.Since the lvm error handling got a bit too big for my taste I moved it into a separate file. I also added a test case to cover this regex style parsing.