lvmd: don't call Close() for stdout #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Go's reference of `StdoutPipe` says: > Wait will close the pipe after seeing the command exit, so most callers > need not close the pipe themselves. It is thus incorrect to call Wait > before all reads from the pipe have completed. https://pkg.go.dev/os/exec#Cmd.StdoutPipe So we don't have to call Close() for stdout. Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
ushitora-anqou
force-pushed
the
lvmd-read-all-from-stdout
branch
from
cd60706
to
21955d5
Compare
ushitora-anqou
changed the title
jakobmoellerdev
approved these changes
Apr 25, 2024
toshipp
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Go's reference of
StdoutPipesays:https://pkg.go.dev/os/exec#Cmd.StdoutPipe
So, io.ReadAll should be called instead of Close.