Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lvmd: avoid fd leaks when error occurs #895

Merged
merged 1 commit into from
Apr 24, 2024
Merged

lvmd: avoid fd leaks when error occurs #895

merged 1 commit into from
Apr 24, 2024

Conversation

ushitora-anqou
Copy link
Contributor

No description provided.

@ushitora-anqou
lvmd: avoid fd leaks when error occurs
029ddcb 
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
jakobmoellerdev
jakobmoellerdev reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@jakobmoellerdev jakobmoellerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, this was definetly an oversight on my part when I rewrote this!

@ushitora-anqou ushitora-anqou marked this pull request as ready for review April 23, 2024 07:07
@ushitora-anqou ushitora-anqou requested a review from a team as a code owner April 23, 2024 07:07
daichimukai
daichimukai approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@daichimukai daichimukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ushitora-anqou ushitora-anqou merged commit 94b7a51 into main Apr 24, 2024
24 checks passed
@ushitora-anqou ushitora-anqou deleted the lvmd-avoid-fd-leak branch April 24, 2024 00:23
@ushitora-anqou
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daichimukai daichimukai daichimukai approved these changes

@jakobmoellerdev jakobmoellerdev jakobmoellerdev approved these changes

@pluser pluser Awaiting requested review from pluser pluser is a code owner automatically assigned from topolvm/reviewers

Assignees
No one assigned
Labels
None yet
Projects
Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ushitora-anqou @daichimukai @jakobmoellerdev