docs: add a note explaining the need for topolvm.io/webhook=ignore
#920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ushitora-anqou
requested changes
May 23, 2024
There was a problem hiding this comment.
I feel that this description is a bit obscure. How about something like this?
The label
topolvm.io/webhook=ignoreis set here to prevent the triggering of TopoLVM's mutating webhooks when pods and pvcs are created in the topolvm-system and kube-system namespaces. These webhooks depend on the topolvm-controller. Therefore, the webhooks should not be activated during TopoLVM's startup process to avoid causing it to become stuck.
In getting started, it is not clear why `topolvm.io/webhook=ignore` is needed. Add a note explaining it. Closes: #907 Signed-off-by: Yuma Ogami <yuma-ogami@cybozu.co.jp>
cupnes
force-pushed
the
explain-topolvm.io-webhook-ignore
branch
from
3ff8162
to
2275580
Compare
|
@ushitora-anqou |
ushitora-anqou
approved these changes
May 24, 2024
pluser
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In getting started, it is not clear why
topolvm.io/webhook=ignoreis needed. Add a note explaining it.Closes: #907