Use the github code block component, and fix a small bug in it. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Create Your Messaging Protocol document now used this newer code box, and it links back to the actual code in our repositories where all of the examples come from. There was also a couple small bugs with how the GitHub URLs are constructed that were fixed.
✅ Deploy Preview for toposware-docs-platform ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Dune1955
approved these changes
Feb 21, 2024
wyhaines
deleted the
kh.switch-messaging-protocol-doc-to-new-codeblocks-20240220
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Create Your Messaging Protocol document now uses this newer code box, and it links back to the actual code in our repositories where all of the examples come from. There was also a couple small bugs with how the GitHub URLs are constructed that were fixed.
This removes some developer friction with learning about the code, as it makes it easier to see, in context, where and how we are actually using it.
PR Checklist: