Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX-716] Avoid fetching scope data to check if it is blank #761

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

dalthon
Copy link
Contributor

@dalthon dalthon commented Feb 12, 2021

Address the issue raised here: #716

There was some unnecessary, possibly heavy, queries being done.


  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the changelog if the new code introduces user-observable changes. See changelog entry format for details.

@dalthon dalthon force-pushed the avoid-unneeded-fecthing-on-import branch from a5d2240 to b2c4d0c Compare February 12, 2021 14:38
@dalthon dalthon merged commit d5ffa79 into master Feb 12, 2021
@dalthon dalthon deleted the avoid-unneeded-fecthing-on-import branch February 12, 2021 15:02
@@ -6,6 +6,8 @@

### Changes

* [#761](https://github.com/toptal/chewy/pull/761): Avoid fetching scope data to check if it is blank ([@dalthon][])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's follow the contributing guide:

If the change has a related GitHub issue (e.g. a bug fix for a reported issue), put a link to the issue as [#123](https://github.com/toptal/chewy/issues/123): 
  • #716: Avoid fetching scope data to check if it is blank ([@dalthon][])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants