-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rubocop to latest and fix as many violations as possible #29
Conversation
4c9ccb2
to
91c32ab
Compare
@toptal-anvil ping reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Autofix did a mostly good job, but some human touch could be nice
5bc554c
to
353a7fe
Compare
353a7fe
to
5f0c343
Compare
Co-authored-by: Ilya Denisov <ilya.denisov@toptal.com>
Co-authored-by: Ilya Denisov <ilya.denisov@toptal.com>
…pec.rb Co-authored-by: Ilya Denisov <ilya.denisov@toptal.com>
…pec.rb Co-authored-by: Ilya Denisov <ilya.denisov@toptal.com>
…ny_spec.rb Co-authored-by: Ilya Denisov <ilya.denisov@toptal.com>
Co-authored-by: Ilya Denisov <ilya.denisov@toptal.com>
Co-authored-by: Ilya Denisov <ilya.denisov@toptal.com>
Co-authored-by: Ilya Denisov <ilya.denisov@toptal.com>
Co-authored-by: Ilya Denisov <ilya.denisov@toptal.com>
…rm into devx-4047-bump-rubocop
As in the title. We were able to fix about 1000 violations in automated manner, I manually fixed a bunch others, but hundreds of violations remain. I created a todo file to cut the work at where it's right now.
granite-form codebase is in a poor shape.
AC: