Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-5178] New Tag colors #4260

Merged
merged 1 commit into from
Apr 25, 2024
Merged

[FX-5178] New Tag colors #4260

merged 1 commit into from
Apr 25, 2024

Conversation

ruslan-sed
Copy link
Contributor

@ruslan-sed ruslan-sed commented Apr 24, 2024

FX-5178

Description

Adds new values for the Tag component variant and indicator props.

How to test

Screenshots

Before. After.
image image

Development checks

Breaking change

  • codemod is created and showcased in the changeset
  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@ruslan-sed ruslan-sed self-assigned this Apr 24, 2024
Copy link

changeset-bot bot commented Apr 24, 2024

🦋 Changeset detected

Latest commit: b3d1395

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@toptal/picasso-tag Minor
@toptal/picasso Patch
@toptal/picasso-page Patch
@toptal/picasso-tagselector Patch
@toptal/picasso-forms Patch
@toptal/picasso-query-builder Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ruslan-sed ruslan-sed force-pushed the fx-5178-new-tag-colors branch 2 times, most recently from a655443 to 55a76b8 Compare April 24, 2024 11:52
@ruslan-sed ruslan-sed requested a review from sashuk April 24, 2024 13:40
@ruslan-sed ruslan-sed marked this pull request as ready for review April 24, 2024 13:40
@ruslan-sed ruslan-sed requested a review from a team as a code owner April 24, 2024 13:40
Copy link
Contributor

@TomasSlama TomasSlama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations to your first PR in FX 🎉

Copy link
Contributor

@sashuk sashuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to join in the congratulations from @TomasSlama, looks great!

@ruslan-sed ruslan-sed merged commit ad19765 into master Apr 25, 2024
18 checks passed
@ruslan-sed ruslan-sed deleted the fx-5178-new-tag-colors branch April 25, 2024 12:06
@toptal-build toptal-build mentioned this pull request Apr 25, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants