-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FX-4593] Migrate tag #4264
[FX-4593] Migrate tag #4264
Conversation
🦋 Changeset detectedLatest commit: bab036d The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bfc0322
to
4fc8ff4
Compare
d84bc53
to
07f9f29
Compare
07f9f29
to
41e0cfa
Compare
@toptal-anvil ping reviewers |
14a0d22
to
af66af6
Compare
679e753
to
d72ceda
Compare
@toptal-bot run package:alpha-release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not test, left few comments. Looks good to go 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left two very small comments, but I will approve to unblock you as it is end of the day for me. Great job 🎉 💪 !
@toptal-bot run package:alpha-release |
Your alpha package is ready 🎉 |
b48d472
to
08a16f7
Compare
1. Update changeset comments 2. Use `@toptal/picasso-tailwind` 3. Remove unnecessary comments 4. Change border width to 1px 5. Use twJoin
08a16f7
to
08e3334
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, thank you! All visual changes are related to font handling, the https://toptal-core.atlassian.net/browse/FX-5297 contains everything that is left to do
FX-4593
Description
This PR migrates
Tag
component to Tailwind. It also removesChip
component because it is not a part of MUI Base.How to test
Development checks
props
in component with documentationexamples
for componentBreaking change
PR commands
List of available commands:
@toptal-bot run package:alpha-release
- Release alpha version@toptal-anvil ping reviewers
- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:
to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle
)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?