Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-4715] Remove deprecated prop from Dropzone #4374

Merged
merged 4 commits into from
Jun 21, 2024

Conversation

AdrianContiu
Copy link
Contributor

@AdrianContiu AdrianContiu commented Jun 20, 2024

FX-4715

Description

This PR removes the deprecated errorMessages prop from Dropzone.

How to test

  • Temploy
  • Check that the errorMessages prop has been removed from the Props section of the Storybook and that the stories are working properly.

Screenshots

Before. After.
image image

Development checks

Breaking change

  • codemod is created and showcased in the changeset
  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@AdrianContiu AdrianContiu self-assigned this Jun 20, 2024
Copy link

changeset-bot bot commented Jun 20, 2024

🦋 Changeset detected

Latest commit: 2172392

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@toptal/picasso-dropzone Major
@toptal/picasso-forms Patch
@toptal/picasso Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AdrianContiu AdrianContiu marked this pull request as ready for review June 20, 2024 14:12
@AdrianContiu AdrianContiu requested a review from a team as a code owner June 20, 2024 14:12
@AdrianContiu AdrianContiu merged commit c5aaee5 into master Jun 21, 2024
18 checks passed
@AdrianContiu AdrianContiu deleted the fx-4715-remove-dropzone-errormessages-prop branch June 21, 2024 13:19
@toptal-build toptal-build mentioned this pull request Jun 21, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants