Skip to content

Commit

Permalink
refactor(data): Remove commented out code
Browse files Browse the repository at this point in the history
  • Loading branch information
tora-pan committed Feb 28, 2023
1 parent e509cd3 commit 5b7d512
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 14 deletions.
3 changes: 2 additions & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,6 @@
"fileMatch": ["/manifest.json"],
"url": "http://json.schemastore.org/chrome-manifest"
}
]
],
"cSpell.words": ["trys"]
}
12 changes: 0 additions & 12 deletions extension/test/data_test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,18 +63,6 @@ describe('data.ts', function () {
rcxDict.wordSearch('ぼんです', /* doNames= */ false)?.data
).to.not.include.something.like({ entry: /^凡打 .*/ });
});
// it('should return break out of loop if charCode is <= 0x3000', function () {
// const nonAsianCharacter = '➾';
// const result = rcxDict.wordSearch(nonAsianCharacter, false);
// expect(result).to.be.null;
// });
// it('should skip conversion of zero-width non-joiner character', function () {
// const wordWithNonJoiner = 'テ‌ス‌ト';
// const result = rcxDict.wordSearch(wordWithNonJoiner, false);
// // expect(result?.data[0].entry).does.not.contain('‌');
// expect(result?.data[0].entry).does.not.contain(String.fromCharCode(8204));
// console.log(result?.data[0].entry);
// });
});
describe('kanjiSearch', function () {
it('should return null for kanji with char code < 0x3000', function () {
Expand Down
3 changes: 2 additions & 1 deletion web-test-runner.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,8 @@ const defaultConfig = {
browsers: [
puppeteerLauncher({
launchOptions: {
executablePath: '/usr/bin/google-chrome',
executablePath:
'/Applications/Google Chrome.app/Contents/MacOS/Google Chrome',
headless: true,
args: chromeArgs,
},
Expand Down

0 comments on commit 5b7d512

Please sign in to comment.