Fix "undefined symbol: luaopen_libpng" when running torch-android #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 27, 2017 15:41
- 'luaopen_libpng' undefined sysbol problem occus due to that system has already loaded "libpng" library in some other place. Then when we try to load same signature 'libpng' library, system would directly return the original library handle which of course there's no 'luaopen_libpng' declared function. - Solution: Rebuild lua 'libpng' library to other name to avoid the library loading conflict.
- align exported func name to "luaopen_libluajit_png".
|
if you could rename it from |
- it make sense to name in 'lua_png', cleaner.
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libpng is a high usage lib for android' image related apps. Thus, when android has already loaded "libpng" module in system, the other "libpng" library generated by torch-image module would have a name conflict issue. Thus, when lua tried to require 'libpng', the dlsym() func would always return the original lib handle, which leads that torch cannot find "luaopen_libpng" exported func.
Solution: we rename this lib to avoid name conflict issue.