-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for CMAKE #62
Conversation
thanks! |
I thank you for your work! It is really cool :-) As I am working on ebuilds for Gentoo for whole Torch subsystem, I identified on my journey few common variables used with LUA or C/C++ LUA bindings:
This is common variable set usually required (not always all of them) for any Torch related package. I also realized that some of the CMAKE configurations are not compatible for some reason, so I am forking every not aligned repo and trying to align them all to something like "TORCH CMAKE STYLE" :-) Thanks again! |
thank you. yes, some cmake files are slightly different than others mostly because many different developers worked on them :) |
While preparing Gentoo ebuilds I addopted the CMAKE way as lots of torch other packages are using it. With CMAKE as build framework I created "more-or-less" common template for any Torch/Lua related stuff and it is quite easy to produce any other ebuild faster.
So I in general added CMakeLists.txt followed by FindReadline.cmake as readline package is required to build against.
Ladislav