Fixed loading indicator dots over logo bug (ampproject#6692)

torch2424 · Jan 3, 2017 · 93cb341 · 93cb341
1 parent 88697d6
commit 93cb341
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 8 deletions.
diff --git a/extensions/amp-playbuzz/0.1/amp-playbuzz.css b/extensions/amp-playbuzz/0.1/amp-playbuzz.css
@@ -68,7 +68,7 @@
 
 .pb_feed_placeholder_preloader {
         position: absolute;
-        top: 50%;
+        top: 47%;
         left: 50%;
         width: 29px;
         height: 38px;
@@ -78,6 +78,19 @@
         box-sizing: border-box;
 }
 
+@media screen and (max-width: 568px) {
+        .pb_feed_placeholder_preloader {
+                top: 46%;
+        }
+}
+
+@media screen and (min-width: 569px) and (max-width: 992px) {
+        .pb_feed_placeholder_preloader {
+                top: 48%;
+        }
+}
+
+
 .pb_feed_anim_mask {
         position: absolute;
         width: 30px;

diff --git a/extensions/amp-playbuzz/0.1/amp-playbuzz.js b/extensions/amp-playbuzz/0.1/amp-playbuzz.js
@@ -195,16 +195,12 @@ class AmpPlaybuzz extends AMP.BaseElement {
     const loaderImage = createElement('img', 'pb_feed_anim_mask');
     loaderImage.src = logo;
 
-    const loaderText = createElement('div', 'pb_feed_loading_text');
-    loaderText.textContent = 'Loading...';
-
     const loadingPlaceholder =
       createElement('div', 'pb_feed_placeholder_container',
         createElement('div', 'pb_feed_placeholder_inner',
-          createElement('div', 'pb_feed_placeholder_content', [
-            createElement('div', 'pb_feed_placeholder_preloader', loaderImage),
-            loaderText,
-          ])));
+          createElement('div', 'pb_feed_placeholder_content',
+            createElement('div', 'pb_feed_placeholder_preloader', loaderImage)
+      )));
 
     return loadingPlaceholder;
   }